Add _GNU_SOURCE definition unconditionally #14651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Autoconf >= 2.70 the _GNU_SOURCE and some other extensions are defined unconditionally regardless whether the __EXTENSIONS__ can be safely defined. Some obsolete Solaris systems once had issues with compiling a default set of standard system headers when __EXTENSIONS__ was defined. Autoconf 2.69 and earlier checked based on that and defined the _GNU_SOURCE conditionally. This condition is not relevant on current systems anymore.
Girgias
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Autoconf >= 2.70 the
_GNU_SOURCEand some other extensions are defined unconditionally regardless whether the__EXTENSIONS__can be safely defined. Some obsolete Solaris systems once had issues with compiling a default set of standard system headers when__EXTENSIONS__was defined. Autoconf 2.69 and earlier checked based on that and defined the_GNU_SOURCEconditionally. This condition is not relevant on current systems anymore.